Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies issues in the cmake machinery #414

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Conversation

GiulioRomualdi
Copy link
Member

This should fix what @S-Dafarra and @isorrentino spotted in #413

Copy link
Member

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traversaro
Copy link
Collaborator

It is possible that we did not spotted this as we are missing some dependency in

for missing_dep in YARP Qhull casadi cppad manif Python3 pybind11 pytest matioCpp LieGroupControllers; do
?

@S-Dafarra
Copy link
Member

It is possible that we did not spotted this as we are missing some dependency in

for missing_dep in YARP Qhull casadi cppad manif Python3 pybind11 pytest matioCpp LieGroupControllers; do

?

Good point!

@GiulioRomualdi
Copy link
Member Author

Lovely vcpkg

2021-09-16T13:52:49.0573896Z CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
2021-09-16T13:52:49.0579814Z     Command failed: msbuild C:/robotology/vcpkg/buildtrees/python3/x64-windows-rel/v3.9.6-ba0c8fc95d.clean/PCbuild/pcbuild.proj /p:Configuration=Release /p:IncludeExtensions=true /p:IncludeExternals=true /p:IncludeCTypes=true /p:IncludeSSL=true /p:IncludeTkinter=false /p:IncludeTests=false /p:ForceImportBeforeCppTargets=C:/robotology/vcpkg/buildtrees/python3/src/v3.9.6-ba0c8fc95d.clean/PCbuild/python_vcpkg.props /p:WindowsTargetPlatformVersion=10.0.22000.0 /p:DefaultWindowsSDKVersion=10.0.22000.0 /p:IncludeUwp=false /p:_VcpkgPythonLinkage=DynamicLibrary /t:Rebuild /p:Platform=x64 /p:PlatformToolset=v142 /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /p:WindowsTargetPlatformVersion=10.0.22000.0 /p:VcpkgTriplet=x64-windows /p:VcpkgInstalledDir=C:/robotology/vcpkg/installed /p:VcpkgManifestInstall=false /m
2021-09-16T13:52:49.0584837Z     Working Directory: C:/robotology/vcpkg/buildtrees/python3/x64-windows-rel/v3.9.6-ba0c8fc95d.clean
2021-09-16T13:52:49.0585620Z     Error code: 1
2021-09-16T13:52:49.0586125Z     See logs for more information:
2021-09-16T13:52:49.0586958Z       C:\robotology\vcpkg\buildtrees\python3\build-x64-windows-rel-out.log
2021-09-16T13:52:49.0587685Z 
2021-09-16T13:52:49.0588162Z Call Stack (most recent call first):
2021-09-16T13:52:49.0588932Z   scripts/cmake/vcpkg_install_msbuild.cmake:169 (vcpkg_execute_required_process)
2021-09-16T13:52:49.0589799Z   ports/python3/portfile.cmake:115 (vcpkg_install_msbuild)
2021-09-16T13:52:49.0591172Z   scripts/ports.cmake:141 (include)
2021-09-16T13:52:49.0592210Z 
2021-09-16T13:52:49.0592530Z 
2021-09-16T13:52:49.0593353Z Error: Building package python3:x64-windows failed with: BUILD_FAILED
2021-09-16T13:52:49.0595081Z Please ensure you're using the latest portfiles with `.\vcpkg update`, then
2021-09-16T13:52:49.0596252Z submit an issue at https://github.com/Microsoft/vcpkg/issues including:
2021-09-16T13:52:49.0597275Z   Package: python3:x64-windows
2021-09-16T13:52:49.0598123Z   Vcpkg version: 2021-07-21-244f69e78da4f97034328b4d290db262d748d4c7
2021-09-16T13:52:49.0598842Z 
2021-09-16T13:52:49.0599691Z Additionally, attach any relevant sections from the log files above.
2021-09-16T13:52:49.3784304Z ##[error]Process completed with exit code 1.

@GiulioRomualdi
Copy link
Member Author

@traversaro, in 3e1e105 I updated the CI test compilation

@traversaro
Copy link
Collaborator

Lovely vcpkg

Python in vcpkg is hopeless for a number of reason. I proposed to just remove it as in Windows are already testing python installed via conda.

@@ -484,7 +484,7 @@ jobs:
shell: bash
run: |
cd build
for missing_dep in YARP Qhull casadi cppad manif Python3 pybind11 pytest matioCpp LieGroupControllers; do
for missing_dep in YARP Qhull casadi cppad manif Python3 pybind11 pytest matioCpp LieGroupControllers nlohmann_json; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spdlog is also missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spdlog is a mandatory dependency :)

@GiulioRomualdi GiulioRomualdi merged commit 5960824 into master Sep 16, 2021
@GiulioRomualdi GiulioRomualdi deleted the fix/cmake branch September 16, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants