-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies issues in the cmake machinery #414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It is possible that we did not spotted this as we are missing some dependency in
|
Good point! |
Lovely
|
@traversaro, in 3e1e105 I updated the CI test compilation |
Python in vcpkg is hopeless for a number of reason. I proposed to just remove it as in Windows are already testing python installed via conda. |
@@ -484,7 +484,7 @@ jobs: | |||
shell: bash | |||
run: | | |||
cd build | |||
for missing_dep in YARP Qhull casadi cppad manif Python3 pybind11 pytest matioCpp LieGroupControllers; do | |||
for missing_dep in YARP Qhull casadi cppad manif Python3 pybind11 pytest matioCpp LieGroupControllers nlohmann_json; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spdlog
is also missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spdlog
is a mandatory dependency :)
This should fix what @S-Dafarra and @isorrentino spotted in #413