Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the compatibility with fmt v9.0.0 #556

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Fix the compatibility with fmt v9.0.0 #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fb0646
Attempt to fix the compatibility with fmt v9.0.0
GiulioRomualdi Sep 5, 2022
752dcb8
Update the CHANGELOG
GiulioRomualdi Sep 5, 2022
1328bb7
Reset the GitHub CI cache to recompile YARP on macOS
GiulioRomualdi Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
uses: actions/cache@v3
with:
path: ${{ github.workspace }}/install/deps
key: source-deps-${{ runner.os }}-os-${{ matrix.os }}-build-type-${{ matrix.build_type }}-vcpkg-robotology-${{ env.vcpkg_robotology_TAG }}-ycm-${{ env.YCM_TAG }}-yarp-${{ env.YARP_TAG }}-iDynTree-${{ env.iDynTree_TAG }}-catch2-${{ env.Catch2_TAG }}-qhull-${{ env.Qhull_TAG }}-casADi-${{ env.CasADi_TAG }}-manif-${{ env.manif_TAG }}-matioCpp-${{ env.matioCpp_TAG }}-LieGroupControllers-${{ env.LieGroupControllers_TAG }}-osqp-${{ env.osqp_TAG }}-osqp-eigen-${{ env.OsqpEigen_TAG }}-tomlplusplus-${{ env.tomlplusplus_TAG }}-unicycle-${{ env.UnicyclePlanner_TAG }}-icub-models-${{ env.icub_models_TAG }}-robometry-${{ env.telemetry_TAG }}
key: blf-source-deps-${{ runner.os }}-os-${{ matrix.os }}-build-type-${{ matrix.build_type }}-vcpkg-robotology-${{ env.vcpkg_robotology_TAG }}-ycm-${{ env.YCM_TAG }}-yarp-${{ env.YARP_TAG }}-iDynTree-${{ env.iDynTree_TAG }}-catch2-${{ env.Catch2_TAG }}-qhull-${{ env.Qhull_TAG }}-casADi-${{ env.CasADi_TAG }}-manif-${{ env.manif_TAG }}-matioCpp-${{ env.matioCpp_TAG }}-LieGroupControllers-${{ env.LieGroupControllers_TAG }}-osqp-${{ env.osqp_TAG }}-osqp-eigen-${{ env.OsqpEigen_TAG }}-tomlplusplus-${{ env.tomlplusplus_TAG }}-unicycle-${{ env.UnicyclePlanner_TAG }}-icub-models-${{ env.icub_models_TAG }}-robometry-${{ env.telemetry_TAG }}


- name: Source-based Dependencies [Windows]
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ All notable changes to this project are documented in this file.
### Changed
### Fix
- Fix the dependency required to compile the YarpRobotLogger device (https://github.com/ami-iit/bipedal-locomotion-framework/pull/554)
- Fix the compatibility with fmt v9.0.0 (https://github.com/ami-iit/bipedal-locomotion-framework/pull/556)

## [0.8.0] - 2022-07-29
### Added
Expand Down
2 changes: 1 addition & 1 deletion src/TextLogging/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ add_bipedal_locomotion_library(
include/BipedalLocomotion/TextLogging/LoggerBuilder.h
include/BipedalLocomotion/TextLogging/DefaultLogger.h
SOURCES src/Logger.cpp src/LoggerBuilder.cpp src/DefaultLogger.cpp
PUBLIC_LINK_LIBRARIES spdlog::spdlog
PUBLIC_LINK_LIBRARIES spdlog::spdlog Eigen3::Eigen
SUBDIRECTORIES YarpImplementation)
13 changes: 13 additions & 0 deletions src/TextLogging/include/BipedalLocomotion/TextLogging/Logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,19 @@
#include <spdlog/spdlog.h>
#include <type_traits>

// This is required only for FMT > v9.0.0
#if (defined(FMT_VERSION) && FMT_VERSION > 90000)
#include <Eigen/Dense>
template <typename _Derived>
struct fmt::formatter<Eigen::DenseBase<_Derived>> : ostream_formatter
{
};
template <typename _Derived>
struct fmt::formatter<Eigen::Transpose<_Derived>> : ostream_formatter
{
};
#endif

namespace BipedalLocomotion
{
namespace TextLogging
Expand Down