Implement blf-balancing-position-control application and YarpTextLogging python bindings #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
force-pushed
the
balancing
branch
from
1282c6f to
d86255e
Compare
GiulioRomualdi
force-pushed
the
balancing
branch
from
490d804 to
07d52e7
Compare
S-Dafarra
reviewed
Feb 27, 2023
|
|
||
| The application will: | ||
| - move the robot CoM following a trajectory specified by the following lists in | ||
| [blf-balancing-position-control-options.ini](./config/robots/ergoCubGazeboV1/blf-balancing-position-control-options.ini) |
There was a problem hiding this comment.
Maybe it is worth having a proper example file?
utilities/balancing-position-control/balancing_position_control/zmp.py
Outdated
Show resolved
Hide resolved
...balancing-position-control/config/robots/ergoCubGazeboV1/balancing_control/robot_control.ini
Outdated
Show resolved
Hide resolved
...ng-position-control/config/robots/ergoCubGazeboV1/blf-balancing-position-control-options.ini
Outdated
Show resolved
Hide resolved
GiulioRomualdi
force-pushed
the
balancing
branch
from
07d52e7 to
1a7926d
Compare
|
Hi @S-Dafarra I added the units in the config files and I added |
S-Dafarra
reviewed
Feb 27, 2023
S-Dafarra
reviewed
Feb 28, 2023
GiulioRomualdi
force-pushed
the
balancing
branch
from
1a7926d to
2c45b5a
Compare
GiulioRomualdi
force-pushed
the
balancing
branch
from
2c45b5a to
501d0c3
Compare
S-Dafarra
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
YarpTextLoggingapplicationThe application will be automatically installed along with the configuration files