Handle the case without force/torque sensors #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Getters | ||
| */ | ||
|
|
||
| /** | ||
| * @brief Access model. | ||
| * @brief Access m_model. |
There was a problem hiding this comment.
I would avoid mentioning m_model you can change the documentation in
Suggested change
| * @brief Access m_model. | |
| * @brief Get the `iDynTree::Model` instance. | |
| * @note The actual implementation of the Model is currently stored in an `iDynTree::Model` |
This is valid also for the others
| * @brief access the length of m_ftList. | ||
| * @return the number of force/torque sensors in the sub-model. | ||
| */ | ||
| int getNrOfFTSensor() const; |
There was a problem hiding this comment.
Suggested change
| int getNrOfFTSensor() const; | |
| std::size_t getNrOfFTSensor() const; |
This is valid also foe the others
S-Dafarra
reviewed
Mar 14, 2023
S-Dafarra
approved these changes
Mar 14, 2023
isorrentino
force-pushed
the
HandleModelNotSplitted
branch
from
317ed70 to
00374c5
Compare
|
The first commit shouldn't be there 😭
|
isorrentino
force-pushed
the
HandleModelNotSplitted
branch
from
00374c5 to
692a0f3
Compare
|
Let's wait for the CI. (I should add the auto-merge CI 🤔 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case without force/torque sensors to split the model was not considered and if the list of sensors was empty we had a segmentation fault error. This PR fixes the problem and now if the user does not specify a list of sensors, the SubModelCreator creates a unique SubModel object corresponding to the full model.