Add the possibility to update the contact list in the swing foot trajectory planner #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested changes
Mar 28, 2023
GiulioRomualdi
force-pushed
the
swing_foot/update_contact_list
branch
from
bec25d0
to
58735d6
Compare
S-Dafarra
approved these changes
Mar 29, 2023
src/Planners/include/BipedalLocomotion/Planners/SwingFootPlanner.h
Outdated
Show resolved
Hide resolved
…ectory planner. - Avoid to reset the internal time of the SwingFootPlanner when a new ContactList is set - Advance must be called before getOutput() - implement `SwingFootPlanner::setTime()`
GiulioRomualdi
force-pushed
the
swing_foot/update_contact_list
branch
from
58735d6
to
110ba83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR it will be possible to update the contact list in the
SwingFootTrajectoryPlanner.If the contact list is not empty, we check if it is possible to update the list. Given some limitations of the framework (mainly due to the SO3 trajectory generation) for the time being, we support only the two following cases:
advance()must be called before getting the output@LoreMoretti you can directly use this class along with the MPC you developed 😄 (cc @traversaro)