-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a class to perform inference with the MANN network #652
Conversation
I guess we can stick to linux only for the time being
That's not desirable. Can't you have a smaller model? |
Regarding the installation procedure, I would go for:
|
Done in robotology/robotology-superbuild#1387 . |
4ee74b0
to
6886bb6
Compare
1f53136
to
f3a3571
Compare
The PR is finally ready to be reviewed. The model is now downloaded while compiling 🚀 |
# BSD-3-Clause license. | ||
|
||
include_directories(${CMAKE_CURRENT_BINARY_DIR}) | ||
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/FolderPath.h.in" "${CMAKE_CURRENT_BINARY_DIR}/MANNModelFolderPath.h" @ONLY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a comment for this PR, but we are getting multiple copies of this file. I wonder if we could move this logic within add_bipedal_test
. Maybe something to automatically generate this file given a path. Anyhow, this is not blocking at all
I think I applied all your suggestions, so in theory, the PR could be merged. However, we need ami-iit/mann-pytorch#5 to get merged before this one (@paolo-viceconte) |
Before proceeding with the review of the PR I would like to discuss with you (@traversaro @S-Dafarra @paolo-viceconte) how to handle these two facts:
Findonnxruntime.cmake
. I tested only on linux. A possibility is to getonnxruntime
with fetchcontent however:.so
andh
in the installation folder. In windows vianuget
add_library(<name> <type> IMPORTED [GLOBAL])
mann-pytorch
and take withfetchcontent