Add support for onnxruntime just on Linux with apt #1387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just when
ROBOTOLOGY_ENABLE_DYNAMICS_FULL_DEPS
is enabled, when we are on Linux and we are not using Conda, this PR adds support for the upcomingFRAMEWORK_USE_onnxruntime
option of bipedal-locomotion-framework (see ami-iit/bipedal-locomotion-framework#652).Differently from most other dependencis handled by the robotology-superbuild, given its size and the time necessary to compile, in this case we do not compile onnxruntime from scratch, but rather we download its binaries at configuration time, and we install them. We do this just on Linux and when conda is not used.
This is just meant to be an initial test. If this binaries create problems of incompatibility with other libraries installed by apt, we will need to find another solution. Instead, for conda-provided dependencies we will try to get onnxruntime also on Windows (see conda-forge/onnxruntime-feedstock#56), and then we could add onnxruntime as any other dependency. However, let's start using this and let's see what happens.