-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the SwingFootPlanner, the Contact component and the CentroidalMPCOutput #721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but: - We need to double check the dT in SwingFootPlanner setContactList - The arms move in a weired way probably this is due to the hight of the CoM - we hardcoded the forward step scaling in MANNTrajectoryGenerator.cpp to half the step size
- add Current time as output of the planner - Update the logic behind the setContactList, updateSE3Traj and createSE3Traj in the planner
This was required to overcome a bug in the SwingFootPlanner when a new contact is established and teh contact phase list is updated. This is not the correct way to fix the bug We noticed that contact name was 'ContactList' instead of left or right foot
…n the CentroidalMPC
…NNAutoregressive and MANNTrajectoryGenerator - Need to double check how the mergePointState scaled previous information are propagated - Need to double check how the com is resetted in MANNAutoregressive::reset - The CoM is currently scaled on its motion direction as the footsteps but we need to check if this is correct
This PR has been split into the following PRs:
Given that we can close this PR without merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.