-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ICentroidalMPC interface and add the StableCentroidalMPC class #734
base: master
Are you sure you want to change the base?
Conversation
Put the PR back in draft in light of https://github.com/ami-iit/element_walking-with-payload/issues/59 |
I am not sure why the
which seems to indicate no memory errors. Any input on the CI failing for the memcheck would be helpful @GiulioRomualdi |
As per suggestion, need to reduce the samples for the unit test. |
6064442
to
c54b8bd
Compare
I did some checks to verify that the CI is not failing for something more important in https://github.com/ami-iit/element_walking-with-payload/issues/53. The CI failure is incidental with no actual memory errors and not reproducible in local machines. Additionally changing the linear solver used (similar to what we do on the robot) significantly reduced computational time required. |
PR is ready for review @GiulioRomualdi @S-Dafarra |
17b1a0f
to
c6d76e5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Now this is not failing anymore. and PR ready for review. |
We take the opportunity of putting this PR back in draft to test
|
This PR replaces the one in #703.
In this PR I will add the
StableCentroidalMPC
as derived class from aICentroidalMPC
together with keeping the original CentroidalMPC implementation unchanged.The idea is also to add the
ParametrizedCentroidalMPC
derived class. However I will leave that to a separate PR till I fix the associated unit test issue and merge this one.