Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the possibility to control a subset of linear coordinates in TSID::SE3Task #738

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Add the possibility to control a subset of linear coordinates in TSID::SE3Task #738

merged 7 commits into from
Oct 12, 2023

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Oct 6, 2023

Fix #725

GiulioRomualdi
GiulioRomualdi reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 🎉
Here you have some minors comment

src/TSID/src/SE3Task.cpp Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/IK/include/BipedalLocomotion/IK/SE3Task.h Outdated Show resolved Hide resolved
@GiulioRomualdi
Copy link
Member

@xela-95 you can also check https://github.com/ami-iit/bipedal-locomotion-framework/actions/runs/6433244451/job/17469917552?pr=738#step:3:40 to remove the whitespaces

xela-95 and others added 2 commits October 6, 2023 22:47
@xela-95 @GiulioRomualdi
Apply suggestions from code review
26d2731 
Co-authored-by: Giulio Romualdi <giulio.romualdi@gmail.com>
@xela-95
Remove trailing whitespaces
78dc783
@xela-95
Copy link
Member Author

xela-95 commented Oct 7, 2023

@xela-95 you can also check https://github.com/ami-iit/bipedal-locomotion-framework/actions/runs/6433244451/job/17469917552?pr=738#step:3:40 to remove the whitespaces

Thank you @GiulioRomualdi, I have removed them.

@Gio-DS
Copy link
Contributor

Gio-DS commented Oct 12, 2023

(actually @traversaro): @GiulioRomualdi can we merge this? Thanks!

@GiulioRomualdi GiulioRomualdi merged commit b210a18 into ami-iit:master Oct 12, 2023
12 checks passed
@traversaro
Copy link
Collaborator

Thanks @GiulioRomualdi !

@GiulioRomualdi
Copy link
Member

Thank you all for the effort :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiulioRomualdi GiulioRomualdi GiulioRomualdi approved these changes

@S-Dafarra S-Dafarra Awaiting requested review from S-Dafarra S-Dafarra is a code owner

Assignees

@xela-95 xela-95

Labels
🔨 component: IK 🔨 component: TSID
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the possibility to control a subset of coordinates in TSID:SE3Task
4 participants
@xela-95 @GiulioRomualdi @Gio-DS @traversaro