Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README in YarpRobotLoggerDevice #779

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

GiulioRomualdi
Copy link
Member

Since this logging device is widely used in the lab, I think we should keep the readme up to date. This PR updates the readme and explains how to log exogenous signal data.

Moreover, it closes #527

cc @G-Cervettini @traversaro @nicktrem @davidegorbani

@GiulioRomualdi
Copy link
Member Author

Failure of the CI tracked in #780

```

### Stream exogenous data
You need to modify the application that streams the exogenous data to open a port with the name specified in the `remote` parameter of the `balancing` sub-group. For example, if you want to stream the data from the your `balancing` application you need to use `BipedalLocomotion::YarpUtilities::VectorsCollectionServer` class as follows
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You need to modify the application that streams the exogenous data to open a port with the name specified in the `remote` parameter of the `balancing` sub-group. For example, if you want to stream the data from the your `balancing` application you need to use `BipedalLocomotion::YarpUtilities::VectorsCollectionServer` class as follows
You need to modify the application that streams the exogenous data to open a port with the name specified in the `remote` parameter of the `balancing` sub-group. For example, if you want to stream the data from your `balancing` application you need to use the `BipedalLocomotion::YarpUtilities::VectorsCollectionServer` class as follows

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automatic merge merges it 😞

@GiulioRomualdi GiulioRomualdi merged commit 7f87fd8 into master Dec 14, 2023
15 checks passed
@GiulioRomualdi GiulioRomualdi deleted the readme_logger branch December 15, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YarpRobotLoggerDevice documentation is not up to date
2 participants