Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional initialization of base pose and feet pose in the Unicycle Trajectory Generator #887

Conversation

LoreMoretti
Copy link
Contributor

This PR add the feature to initialize the unicycleTrajectoryGenerator with the initial base pose and the relative pose of the feet (which mimics what is done in TrajectoryGenerator.cpp in the generateFirstTrajectories member functions)

@LoreMoretti LoreMoretti marked this pull request as ready for review September 16, 2024 14:31
@S-Dafarra
Copy link
Member

Look good to me! I would suggest adding a basic test for the additions

@LoreMoretti
Copy link
Contributor Author

Look good to me! I would suggest adding a basic test for the additions

Thanks @S-Dafarra.

Indeed, when writing the new tests and compiling them, I found out that the signatures:

bool Planners::UnicycleTrajectoryGenerator::initialize(
    std::weak_ptr<const ParametersHandler::IParametersHandler> handler,
    const manif::SE3d& leftToRightTransform)


bool Planners::UnicycleTrajectoryGenerator::initialize(
    std::weak_ptr<const ParametersHandler::IParametersHandler> handler,
    const Eigen::Ref<const Eigen::Vector3d>& initialBasePosition)

seem to be ambiguous.

The only way I found so far is to pass initialBasePosition as const Eigen::Vector3d& instead of const Eigen::Ref<const Eigen::Vector3d>&. I know this reduces flexibility, but I could not find another way.

@GiulioRomualdi GiulioRomualdi enabled auto-merge (squash) October 1, 2024 10:10
@GiulioRomualdi
Copy link
Member

CI on conda fails with: #896

@GiulioRomualdi GiulioRomualdi merged commit d7025e9 into ami-iit:master Oct 1, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants