-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement low-pass filter for estimated friction torque #892
Merged
GiulioRomualdi
merged 6 commits into
ami-iit:master
from
isorrentino:hjtc/additional_features
Sep 25, 2024
Merged
Implement low-pass filter for estimated friction torque #892
GiulioRomualdi
merged 6 commits into
ami-iit:master
from
isorrentino:hjtc/additional_features
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8048f86
to
59d7ba2
Compare
59d7ba2
to
b45d20f
Compare
Hi @isorrentino can you remove the white space? |
b45d20f
to
632013f
Compare
Done |
GiulioRomualdi
requested changes
Sep 23, 2024
@@ -66,13 +67,15 @@ struct MotorTorqueCurrentParameters | |||
double kp; /**< proportional gain */ | |||
double maxCurr; /**< maximum current */ | |||
std::string frictionModel; ///< friction model | |||
double max_output_friction; /**< maximum output of the friction model */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the style of the remaining part of the code?
475d614
to
9afee9a
Compare
9afee9a sob. I've fixed the changelog manually :( |
GiulioRomualdi
approved these changes
Sep 25, 2024
Hi @GiulioRomualdi I think the failure is not related to this PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements: