Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug related to prepare_data() method calling #895

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

fils99
Copy link
Contributor

@fils99 fils99 commented Oct 1, 2024

This PR fixes the bug found in https://github.com/ami-iit/element_pi-ft-modeling/issues/96#issuecomment-2383535504. Basically, the output type of the method prepare_data() should be void, while in d63fa9f#diff-41b66f0e3904e0ce5ecc91e8dff26a004e80b7b6f1c27b81874d5b6554ce3154 the output is considered as bool. With this PR, the method is called in the proper way.

cc @GiulioRomualdi

@GiulioRomualdi
Copy link
Member

Thank you @fils99 Can you modify the changelog?

@fils99
Copy link
Contributor Author

fils99 commented Oct 1, 2024

Thank you @fils99 Can you modify the changelog?

Done in fils99@94846f7

@GiulioRomualdi
Copy link
Member

CI on conda fails with: #896

@GiulioRomualdi GiulioRomualdi merged commit 3f19707 into ami-iit:master Oct 1, 2024
7 of 10 checks passed
@fils99 fils99 deleted the fils99-patch0 branch October 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants