-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate jaxsim.api
package away from PhysicsModel
#112
Conversation
4e318f5
to
b824a83
Compare
b824a83
to
8d887a3
Compare
ecd7f69
to
063e866
Compare
They accept now JaxSimModel instead of the old low-level PhysicsModel
063e866
to
f62655b
Compare
3e7277a
to
5e9f93b
Compare
6fd2197
to
0ed97b9
Compare
All the functionalities should be now redirected to the new KinDynParameters
0ed97b9
to
1b4a528
Compare
PhysicsModel
jaxsim.api
package away from PhysicsModel
Waiting @flferretti to be back, I added @traversaro as reviewer. This PR is not merging into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I just realized that the removal of |
Great! |
PhysicsModel
in favor of the combination ofJaxSimModel
and the newKinDynParameters
.jaxsim.rbda
.jaxsim.terrain
.ODE{State|Input}
,PhysicsModel{State|Input}
,SoftContactsState
tojaxsim.api.ode_data
.VelRepr
tojaxsim.api.common
.jaxsim.sixd
pass-through in favor of plainjaxlie
.jaxsim.rbda
to useJaxSimModel
instead ofPhysicsModel
.RBDAs
.The unused classes will be removed in another PR. In this one, the aim is to make everything work with the new
KinDynParameters
class introduced in #101.📚 Documentation preview 📚: https://jaxsim--112.org.readthedocs.build//112/