Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to the latest API #124

Merged
merged 22 commits into from
Apr 3, 2024
Merged

Update documentation to the latest API #124

merged 22 commits into from
Apr 3, 2024

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Mar 27, 2024

This pull request updates the documentation according to the latest API


📚 Documentation preview 📚: https://jaxsim--124.org.readthedocs.build//124/

@flferretti flferretti self-assigned this Mar 27, 2024
@flferretti flferretti force-pushed the update_docs branch 3 times, most recently from 24d35e4 to cfb633d Compare March 28, 2024 12:32
@flferretti flferretti marked this pull request as ready for review March 28, 2024 12:33
@flferretti flferretti requested a review from diegoferigo as a code owner March 28, 2024 12:33
Base automatically changed from functional to main March 29, 2024 09:20
@flferretti flferretti force-pushed the update_docs branch 3 times, most recently from 591a8c5 to 05f0ef5 Compare April 2, 2024 10:50
@flferretti
Copy link
Collaborator Author

@diegoferigo the PR is ready for review, I had some troubles with RTD as apparently it doesn't set the CONDA_PREFIX env key, which is used when importing mujoco (see recipe)

fyi @traversaro

Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! It looks good for the upcoming release. We can enhance the documentation in future PRs, if needed.

@flferretti flferretti merged commit d3728a0 into main Apr 3, 2024
21 checks passed
@flferretti flferretti deleted the update_docs branch April 3, 2024 10:53
@traversaro
Copy link
Contributor

@diegoferigo the PR is ready for review, I had some troubles with RTD as apparently it doesn't set the CONDA_PREFIX env key, which is used when importing mujoco (see recipe)

fyi @traversaro

Oh no, that was my nightmare scenario when I wrote that patch. Do you have any idea how they can run conda-based python without setting CONDA_PREFIX? See readthedocs/readthedocs.org#4067 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants