Extend test of link bias acceleration #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks!! |
flferretti
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Thanks a lot Diego! If there's no rush in merging this, can we think about adding also the test for the mixed representation? Otherwise, I believe it would be nice to refactor the if-condition using match-case eventually adding a:
match VelRepr.Mixed:
# TODO: [Insert comment here on why we don't test Mixed]
passso that we can work on that in the future. What do you think?
diegoferigo
force-pushed
the
extend_test_of_link_bias_acceleration
branch
from
414a8b6 to
f98bed8
Compare
diegoferigo
force-pushed
the
extend_test_of_link_bias_acceleration
branch
from
f98bed8 to
6ac0471
Compare
I don't want to dedicate additional effort towards this now. Merging without mixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to make sure that the calculation needed by @xela-95 were correct. Apparently they are, and I took advantage of this check to extend the test.
📚 Documentation preview 📚: https://jaxsim--185.org.readthedocs.build//185/