-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 32bit simulations #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flferretti
force-pushed
the
feature/single_precision_support
branch
3 times, most recently
from
September 12, 2024 08:10
4d1a65c
to
2f19c26
Compare
flferretti
force-pushed
the
feature/single_precision_support
branch
from
September 12, 2024 08:15
2f19c26
to
e36fd75
Compare
diegoferigo
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Though, I'm wondering if we can address the overflow in cases when possible.
flferretti
force-pushed
the
feature/single_precision_support
branch
from
September 12, 2024 10:11
051704a
to
cc3db28
Compare
Co-authored-by: Diego Ferigo <diego.ferigo@iit.it>
flferretti
force-pushed
the
feature/single_precision_support
branch
from
September 12, 2024 10:31
cc3db28
to
5937074
Compare
flferretti
force-pushed
the
feature/single_precision_support
branch
from
September 12, 2024 10:58
5937074
to
e054cc7
Compare
diegoferigo
reviewed
Sep 12, 2024
flferretti
force-pushed
the
feature/single_precision_support
branch
2 times, most recently
from
September 12, 2024 13:18
ca48040
to
5777a0a
Compare
Co-authored-by: Diego Ferigo <diego.ferigo@iit.it>
flferretti
force-pushed
the
feature/single_precision_support
branch
from
September 12, 2024 13:38
5777a0a
to
fac6351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds experimental support for 32bit simulations. In order to use it, the user can set
JAX_ENABLE_X64=0
Closes #136
📚 Documentation preview 📚: https://jaxsim--225.org.readthedocs.build//225/