Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 32bit simulations #225

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Sep 5, 2024

This PR adds experimental support for 32bit simulations. In order to use it, the user can set JAX_ENABLE_X64=0

Closes #136


📚 Documentation preview 📚: https://jaxsim--225.org.readthedocs.build//225/

@flferretti flferretti self-assigned this Sep 5, 2024
@flferretti flferretti force-pushed the feature/single_precision_support branch 3 times, most recently from 4d1a65c to 2f19c26 Compare September 12, 2024 08:10
@flferretti flferretti force-pushed the feature/single_precision_support branch from 2f19c26 to e36fd75 Compare September 12, 2024 08:15
@flferretti flferretti marked this pull request as ready for review September 12, 2024 08:16
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though, I'm wondering if we can address the overflow in cases when possible.

src/jaxsim/api/model.py Outdated Show resolved Hide resolved
src/jaxsim/api/model.py Outdated Show resolved Hide resolved
src/jaxsim/api/model.py Outdated Show resolved Hide resolved
@flferretti flferretti force-pushed the feature/single_precision_support branch from 051704a to cc3db28 Compare September 12, 2024 10:11
@flferretti flferretti force-pushed the feature/single_precision_support branch from cc3db28 to 5937074 Compare September 12, 2024 10:31
@flferretti flferretti force-pushed the feature/single_precision_support branch from 5937074 to e054cc7 Compare September 12, 2024 10:58
src/jaxsim/api/data.py Outdated Show resolved Hide resolved
@flferretti flferretti force-pushed the feature/single_precision_support branch 2 times, most recently from ca48040 to 5777a0a Compare September 12, 2024 13:18
@flferretti flferretti force-pushed the feature/single_precision_support branch from 5777a0a to fac6351 Compare September 12, 2024 13:38
@flferretti flferretti merged commit 58b803c into main Sep 12, 2024
24 checks passed
@flferretti flferretti deleted the feature/single_precision_support branch September 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performing a simulation enforcing JAX to run in 32-bit precision overflows after 4.29 seconds
2 participants