Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for joint torques in the rigid contact models #233

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Sep 17, 2024

This pull request includes several updates to the contact models in the codebase. The jaxsim.api.contact.collidable_point_dynamics function now takes into account the applied torques in the rigid contact models. The RelaxedRigidContacts class have been updated to include docstrings and a deprecation warning on jax.tree_map has been fixed


📚 Documentation preview 📚: https://jaxsim--233.org.readthedocs.build//233/

@flferretti flferretti changed the title Account for jo0int torques in the rigid contact models Account for joint torques in the rigid contact models Sep 17, 2024
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix. If you think it's worth, feel free to split the update of tree map calls into another PR.

src/jaxsim/api/kin_dyn_parameters.py Outdated Show resolved Hide resolved
src/jaxsim/rbda/contacts/relaxed_rigid.py Outdated Show resolved Hide resolved
@flferretti flferretti force-pushed the fix/apply_torques_contacts branch from 5ecf4e8 to 318ee34 Compare September 18, 2024 08:05
@flferretti flferretti force-pushed the fix/apply_torques_contacts branch from 64bef4d to df74b44 Compare September 18, 2024 08:19
@flferretti flferretti merged commit 04942c4 into main Sep 18, 2024
23 of 24 checks passed
@flferretti flferretti deleted the fix/apply_torques_contacts branch September 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants