-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove absolute time from JaxSimModelData
and introduce JaxSimModel.time_step
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
force-pushed
the
remove_time_from_data
branch
from
October 11, 2024 08:39
e01ec46
to
e43f736
Compare
diegoferigo
force-pushed
the
remove_time_from_data
branch
2 times, most recently
from
October 11, 2024 08:57
954f144
to
90471db
Compare
This was referenced Oct 11, 2024
Closed
flferretti
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Diego! This was very much needed! I just left a couple comments
diegoferigo
force-pushed
the
remove_time_from_data
branch
from
October 11, 2024 09:42
90471db
to
f4161ec
Compare
flferretti
requested changes
Oct 11, 2024
Co-authored-by: Filippo Luca Ferretti <102977828+flferretti@users.noreply.github.com>
flferretti
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm finally addressing a longstanding problem that complicated the usage of 32-bit precision as described in #136. After having explored more complex solutions, we decided to stop tracking the absolute simulation time within JaxSim, moving the responsibility to downstream code if necessary.
More details:
JaxSimData.time()
andJaxSimData.time_ns
.JaxSimModel.time_step
that stores the default integrationt0
argument tojaxsim.api.model.step
, so that it's still possible to run AD w.r.t. the time if the dynamics considered by the integrator is time-dependent (this is rarely the case).📚 Documentation preview 📚: https://jaxsim--262.org.readthedocs.build//262/