Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --forked from pytest as workaround for jax 0.4.25 #94

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 27, 2024


📚 Documentation preview 📚: https://jaxsim--94.org.readthedocs.build//94/

Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @traversaro, LGTM

@flferretti flferretti merged commit 6eaf105 into flferretti-patch-1 Feb 27, 2024
17 of 20 checks passed
@flferretti flferretti deleted the fixnewjaxcrash branch February 27, 2024 13:16
@diegoferigo
Copy link
Member

For the records, the --forked was necessary in the past otherwise jax was failing due to multiple jitted functions running of different pytrees with same structure. I never investigated the real reason of failure, and found a quick workaround by running all tests on different processes.

If now CI works without it, I agree on removing --forked.

@traversaro
Copy link
Contributor Author

Actually the problem was different here, I just forgot to close the PR. With jax 0.4.25 --forked was making the test fail, but since we are not using 0.4.25 we could also leave it there.

@diegoferigo
Copy link
Member

If --forked is no longer necessary also for jax<0.4.25, I'd prefer to keep the tests without it. It makes the tests run slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants