28-integration-in-ci #29
Conversation
| self::flushDirectories('lang', 'views'); | ||
| } | ||
|
|
||
| public function testLocalizeCommandReturnsNonZeroCodeThenZeroCodeIfFileDidNotChangedBetweenTwoRun(): void |
There was a problem hiding this comment.
This one will not pass, because I feel I will need something new that seems to not exist yet. Let me explain:
For this test to pass, the parser should detect, among the keys it has collected, which ones are not yet in all translated files. This seems like this piece of logic mixes both the Parser and the Writers, since the Writers are aware of which translations files contains which keys, when the Parser only knows which keys are in the "app" files.
My first suggestion would be to have a method Parser::foundSomeNewKeysComparedTo(Collection $keys): bool.
What do you think about it @amiranagram?
There was a problem hiding this comment.
Good job overall!
As for this you can use Amirami\Localizator\Services\Localizator class to merge the keys together and figure out if there are any. Look at the collect method there, it does everything. You can make it public.
So like:
$localizator->collect($parser->getKeys($locale, $type), $type, $locale);Obviously need to loop over all types and locales.
This PR adds a new
--ci(or-c) flag to instruct the command to return a non zero code in case some untranslated keys have been found.