Skip to content

Commit a6c2419

Browse files
njhillamitm02
authored andcommitted
[BugFix] Fix incorrect metrics shutdown error log message (vllm-project#18992)
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: amit <amit.man@gmail.com>
1 parent b9e8375 commit a6c2419

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

vllm/v1/metrics/prometheus.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,13 @@ def unregister_vllm_metrics():
6969

7070
def shutdown_prometheus():
7171
"""Shutdown prometheus metrics."""
72+
73+
path = _prometheus_multiproc_dir
74+
if path is None:
75+
return
7276
try:
7377
pid = os.getpid()
74-
multiprocess.mark_process_dead(pid)
78+
multiprocess.mark_process_dead(pid, path)
7579
logger.debug("Marked Prometheus metrics for process %d as dead", pid)
7680
except Exception as e:
7781
logger.error("Error during metrics cleanup: %s", str(e))

0 commit comments

Comments
 (0)