Skip to content

[BugFix] Fix incorrect metrics shutdown error log message #18992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

[BugFix] Fix incorrect metrics shutdown error log message #18992

merged 1 commit into from
Jun 1, 2025

Conversation

@njhill
Copy link
Member

@njhill njhill commented May 31, 2025 •
edited by github-actions bot
Loading

Introduced in #17546. We should only call mark_process_dead when we're using prometheus multiprocessing mode (with > 1 API servers).

ERROR 05-31 01:04:14 [prometheus.py:77] Error during metrics cleanup: expected str, bytes or os.PathLike object, not NoneType

Thanks to @lgeiger for reporting.

@njhill
[BugFix] Fix incorrect metrics shutdown error message
30fbba9 
Introduced in vllm-project#17546. We should only call mark_process_dead when we're using prometheus multiprocessing mode (with > 1 API servers).

Signed-off-by: Nick Hill <nhill@redhat.com>
@github-actions
Copy link

github-actions bot commented May 31, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 31, 2025
@njhill njhill mentioned this pull request May 31, 2025
Merged
6 tasks
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label May 31, 2025
houseroad
houseroad approved these changes Jun 1, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DarkLight1337 DarkLight1337 merged commit 2b102d5 into vllm-project:main Jun 1, 2025
73 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@njhill @amitm02
[BugFix] Fix incorrect metrics shutdown error log message (vllm-proje…
a6c2419 
…ct#18992)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: amit <amit.man@gmail.com>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@njhill @amitm02
[BugFix] Fix incorrect metrics shutdown error log message (vllm-proje…
4e0185b 
…ct#18992)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: amit <amit.man@gmail.com>
@njhill njhill deleted the fix-mp-prom-warning branch June 2, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

+1 more reviewer

@lgeiger lgeiger lgeiger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@njhill @lgeiger @houseroad @DarkLight1337