Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to bypass observability system for performance; Avoid unnecessary observable notifications of @observable fields of Stores; Fix Reaction lacks toString, so cannot see which reaction causes the error; Add StackTrace to reactions in debug mode to easily spot which reaction it is #1

Merged
merged 23 commits into from
Jan 27, 2023
Merged

Allow users to bypass observability system for performance; Avoid unnecessary observable notifications of @observable fields of Stores; Fix Reaction lacks toString, so cannot see which reaction causes the error; Add StackTrace to reactions in debug mode to easily spot which reaction it is #1

merged 23 commits into from
Jan 27, 2023

Conversation

amondnet
Copy link
Owner

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melo run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

fzyzcjy and others added 23 commits July 12, 2022 20:59
@fzyzcjy
add nonObservableInner, such that users can bypass observability sy…
880ee28 
…stem for performance
@fzyzcjy
Merge remote-tracking branch 'origin/master'
5a58d06
@fzyzcjy
chore: format code
e1df03a
@fzyzcjy
feat: Add onDispose callback to Computed, such that old values ca…
bbd9020 
…n be properly disposed mobxjs#857
@fzyzcjy
test: add tests to disposeValue mobxjs#857
263155b
@fzyzcjy
test: add tests for "Allow users to bypass observability system for p…
396cd93 
…erformance"
@fzyzcjy
feat: add Computed.dispose mobxjs#859
20fe5d3
@fzyzcjy
test: add tests for Computed.dispose
63d57ef
@fzyzcjy
test: reproduce mobxjs#855
ada24f7
@fzyzcjy
fix: Avoid unnecessary observable notifications of @observable fiel…
3b93039 
…ds of `Store`s mobxjs#855
@fzyzcjy
Merge pull request #4 from mobxjs/master
919f203 
merge from upstream
@fzyzcjy
Revert "test: add tests for Computed.dispose"
305bd4e 
This reverts commit 63d57ef.
@fzyzcjy
Revert "feat: add Computed.dispose mobxjs#859"
3912572 
This reverts commit 20fe5d3.
@fzyzcjy
Revert "test: add tests to disposeValue mobxjs#857"
290f8c3 
This reverts commit 263155b.

# Conflicts:
#	mobx/test/computed_test.dart
@fzyzcjy
Revert "feat: Add onDispose callback to Computed, such that old v…
424ec02 
…alues can be properly disposed mobxjs#857"

This reverts commit bbd9020.
@fzyzcjy
format code and minor change to code
fcc222b
@fzyzcjy
add Observable.nonObservableValue
637d12b
@fzyzcjy
fix: Reaction lacks toString, so cannot see which reaction causes the…
e852b9b 
… error mobxjs#864
@fzyzcjy
feat: Add StackTrace to reactions in debug mode to easily spot which …
75260bf 
…reaction it is mobxjs#864
@fzyzcjy
fix linter errors
fecb442
@fzyzcjy
add toString and debugCreationStack
1803928
@amondnet
Merge branch 'master' into master
015d35f
@amondnet
Merge branch 'master' into master
74ea2e5
@amondnet amondnet merged commit 0a2b5c8 into amondnet:gh-844 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amondnet @fzyzcjy