Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Future::error rather than abandoning #93

Merged
merged 3 commits into from
Jan 30, 2022
Merged

Return Future::error rather than abandoning #93

merged 3 commits into from
Jan 30, 2022

Conversation

iggyvolz
Copy link
Contributor

@iggyvolz iggyvolz commented Jan 8, 2022

@kelunik
Copy link
Member

kelunik commented Jan 8, 2022

Whoops, thanks! Could you add psalm suppressions to get the build green?

@kelunik kelunik merged commit 5d42e56 into amphp:v2 Jan 30, 2022
@kelunik
Copy link
Member

kelunik commented Jan 30, 2022

Thanks!

@iggyvolz iggyvolz deleted the v2 branch January 30, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iggyvolz @kelunik