Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Future::error rather than abandoning #93

Merged
merged 3 commits into from
Jan 30, 2022
Merged

Return Future::error rather than abandoning #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51072c0
Return Future::error rather than abandoning
iggyvolz Jan 8, 2022
25427f4
Change return type of AsyncWriter::write
iggyvolz Jan 8, 2022
16a797d
Merge branch 'amphp:v2' into v2
iggyvolz Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/AsyncWriter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ public function __destruct()
*
* @param string $bytes
*
* @return Future<void>
* @return Future<never>
*/
public function write(string $bytes): Future
{
if (!$this->isWritable()) {
Future::error(new ClosedException('The destination stream is no longer writable'));
return Future::error(new ClosedException('The destination stream is no longer writable'));
}

$deferredFuture = new DeferredFuture();
Expand All @@ -103,7 +103,7 @@ public function write(string $bytes): Future
public function end(): Future
{
if (!$this->isWritable()) {
Future::error(new ClosedException('The destination stream is no longer writable'));
return Future::error(new ClosedException('The destination stream is no longer writable'));
}

$this->destination = null;
Expand Down