-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[owners] Support reviewerPool
of users and/or teams in place of reviewerTeam
property
#1284
Conversation
@rsimha Can you make the necessary changes on the amphtml side and I'll handle re-deploying this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! LGTM with a few nits.
Happy to help coordinate this change with the one needed in amphtml
.
SG. I've sent out ampproject/amphtml#34176 for review. I can help coordinate the merging of it with this PR. |
@rsimha FYI CircleCI migration may have introduced a bug in built target detection: Locally I get the correct set of build targets, suggesting it may be due to the |
Could be due to GH actions. Thanks for the heads up. Will address this via a separate fix. Edit: Addressed in #1307, confirmed in #1307 (comment). |
Closes #1283
Requires an update to amphtml's root OWNERS file, but this should not fail any PRs on that repo in the interim unless they trigger OWNERS build target. Will require pushing an updated deploy tag to trigger a build.
Before:
reviewerTeam
allowed only in repo rootOWNERS
file, must be a string representing a teamNow:
reviewerPool
allowed only in repo root `OWNERShi file, must be an array of strings representing teams or usernames