Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main branch name used during CI #1288

Merged
merged 2 commits into from
May 4, 2021
Merged

Update main branch name used during CI #1288

merged 2 commits into from
May 4, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 4, 2021

During build target computation, we look at the set of files changed by a PR when compared with the common ancestor commit with the main branch. On Travis, it was sufficient to use main, but on GH actions, we need to use origin/main.

For evidence, see this screenshot from an amphtml GH Actions build:

image

Addresses #1284 (comment)

@rsimha rsimha requested a review from rcebulko May 4, 2021 21:04
@rsimha rsimha self-assigned this May 4, 2021
build-system/git.js Outdated Show resolved Hide resolved
@rsimha rsimha merged commit cf1f6f6 into ampproject:main May 4, 2021
@rsimha rsimha deleted the 2021-05-04-MainBaseline branch May 4, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants