-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume bundles.config.extensions.json
to amend TagWithExtensionSpec
classes with extension version meta
#297
Conversation
7203aad
to
23b07c2
Compare
bundles.config.extensions.json
to amend TagWithExtensionSpec
classes with extension version meta
1f97e65
to
09163d8
Compare
I added the |
The AMP project contains extension version information in a bundles config file: https://github.com/ampproject/amphtml/blob/main/build-system/compile/bundles.config.extensions.json
This information is complementary to what is located in the validator spec. It has key information including what specific version the the
latest
version corresponds and what versions are available as Bento components.This PR augments
TagWithExtensionSpec
to include this additional extension version information.It still feels somewhat not-ideal that the the extension version information gets split apart into multiple
TagWithExtensionSpec
classes. For example,amp-twitter
scripts have aScriptAmpTwitter
and aScriptAmpTwitter2
class. The former is the classic AMP component version whereas the latter is the Bento version. Both of these classes have aLATEST_VERSION
which points to0.1
, and theversions
of the former include0.1
but the later includes just1.0
. So this may not be the most ergonomic way to store/access this information.Feel free to take over this PR and make changes that seem best to you. Maybe we shouldn't be extending
TagWithExtensionSpec
classes in the first place and it would be better to represent this information in a separate set of classes.