Update amphtml spec to dc6cd22a52 #6530
Conversation
| array( | ||
| 'attr_spec_list' => array( | ||
| 'data-href' => array( | ||
| 'mandatory' => true, | ||
| ), | ||
| 'media' => array(), | ||
| 'noloading' => array( | ||
| 'value' => array( | ||
| '', | ||
| ), | ||
| ), | ||
| ), | ||
| 'tag_spec' => array( | ||
| 'amp_layout' => array( | ||
| 'supported_layouts' => array( | ||
| 6, | ||
| 2, | ||
| 3, | ||
| 7, | ||
| 1, | ||
| 4, | ||
| ), | ||
| ), | ||
| 'requires_extension' => array( | ||
| 'amp-facebook', | ||
| ), | ||
| 'spec_name' => 'amp-facebook-comments 1.0', | ||
| ), | ||
| ), |
There was a problem hiding this comment.
This is problematic for our existing auto-extension importing logic, since the two versions look the same but one requires amp-facebook-comments and the other requires amp-facebook.
There was a problem hiding this comment.
There was a problem hiding this comment.
We need to add a new bento boolean flag to each tag_spec that requires_extension so we can easily differentiate between Bento and non-Bento specs.
There was a problem hiding this comment.
Or rather, requires_extension should be a mapping from component to the version(s). In this way, we could supply to components and versions that we are wanting and it can automatically omit tag specs that don't have a matching version.
|
Plugin builds for 69b99b0 are ready 🛎️!
|
westonruter
force-pushed
the
update/amphtml-spec-20210811
branch
from
0688b00 to
6e282a3
Compare
westonruter
force-pushed
the
update/amphtml-spec-20210811
branch
from
6e282a3 to
7406336
Compare
| if ( | ||
| isset( $rule_spec['tag_spec']['bento'] ) | ||
| && | ||
| $this->args['prefer_bento'] !== $rule_spec['tag_spec']['bento'] |
There was a problem hiding this comment.
I know this is temporary, but just a note that this will load the bento and non-bento versions once the prefer_bento argument is true.
There was a problem hiding this comment.
When prefer_bento is true, then it will exclude the Bento versions because where bento => false.
There was a problem hiding this comment.
Ah OK I missed the bento => false, this is good then 👍.
Co-authored-by: Pierre Gordon <16200219+pierlon@users.noreply.github.com>
Co-authored-by: Pierre Gordon <pierregordon@protonmail.com>
…-2.1 [2.1] Update amphtml spec to dc6cd22a52 (#6530)
|
QA Passed I added a Custom HTML block with the following markup: <amp-base-carousel layout="responsive" height="1" width="2" auto-advance="true" auto-advance-interval="500" loop>
<div>1</div>
<div>2</div>
<div>3</div>
</amp-base-carousel>Notice boolean Before this was a validation error but after this is now no longer flagged as an issue (and the carousel loops as expected).
|
Previously #6436.
./bin/amphtml-update.sh(lando ssh -c 'bash ./bin/amphtml-update.sh vendor/amphtml').Changelog
loopas boolean attribute onamp-base-carousel,amp-inline-gallery-thumbnails, andamp-stream-gallery. See Validation ofloopattribute swissspidy/gutenberg-bento#1 and Cannot use loop as boolean attribute for amp-base-carousel amphtml#35555.amp-brightcove(v1.0) as Bento component.amp-facebook(v1.0) as Bento component (includingamp-facebook-comments,amp-facebook-like, andamp-facebook-page). This required some hoops to go through since there are Bento-specific tag specs which are identical to the non-Bento tag specs except that the Bento version requiresamp-facebook(1.0) and the non-Bento versions require their own respective non-Bento scripts. I'm not super happy with the changes toamphtml-update.pybut they'll hold us over for now, given that we'll be replacing the plugin's entire spec generation with the spec fromamp-toolbox-php(see Consumebundles.config.extensions.jsonto amendTagWithExtensionSpecclasses with extension version meta amp-toolbox-php#297). See also Bento: Validate Facebook components amphtml#35395 (comment).amp-renderinamp-story.data-amp-autocomplete-opt-invalidator hack.Details
( PREV_VERSION=ed0504b; THIS_VERSION=dc6cd22a52; git checkout $THIS_VERSION; git diff $PREV_VERSION...$THIS_VERSION -w -- $( git ls-files | grep '.protoascii' ); git checkout - > /dev/null )