Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand/collapse all header arrows are not aligned properly #2078

Closed
westonruter opened this issue Apr 7, 2019 · 2 comments · Fixed by #3599
Closed

Expand/collapse all header arrows are not aligned properly #2078

westonruter opened this issue Apr 7, 2019 · 2 comments · Fixed by #3599
Labels
Bug Something isn't working Good First Issue

Comments

@westonruter
Copy link
Member

image

image

The issue is more pronounced when focus styles are applied:

image

image

@westonruter westonruter added Bug Something isn't working Good First Issue labels Apr 7, 2019
@westonruter westonruter added this to the v1.1 milestone Apr 7, 2019
@westonruter westonruter modified the milestones: v1.1, v1.2 Apr 16, 2019
@westonruter westonruter modified the milestones: v1.2, v1.3 Jun 7, 2019
@archon810
Copy link

Can I propose modifying this ticket to redesign these altogether?

  1. Alignment aside, these look ambiguous and broken - I thought it was an accidentally showing 2nd arrow that was out of place or something.
  2. I had no idea these were collapse/uncollapse buttons. In fact, I thought they were sort up/down buttons. There are better ways to show collapse/uncollapse. For example, [+] and [-], or something similar to this but less ugly:
    image

I think in general for the actual rows, it's better to use an unfilled arrow to show collapsing/uncollapsing, for example https://dribbble.com/shots/5976164-Simple-Drawer-Animation.

@MackenzieHartung MackenzieHartung modified the milestones: v1.3, v1.3.1 Sep 17, 2019
@swissspidy swissspidy modified the milestones: v1.3.1, v1.4 Oct 17, 2019
@westonruter westonruter removed this from the v1.4 milestone Oct 17, 2019
@westonruter westonruter self-assigned this Oct 22, 2019
westonruter added a commit that referenced this issue Oct 22, 2019
@csossi
Copy link

csossi commented Oct 30, 2019

Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants