-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improve compatibility tool design and UX #3599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unused function arg
amedina
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #2316. Follow up on #3505.
Improve table row styling (before/after)
Ensure bulk accept/reject buttons cause new state to be cleared for validation errors on validated URL screen (before/after)
This aligns the behavior for when just changing the status in the dropdown.
Improve sources list (before/after)
details > summary
acursor:pointer
and disableuser-select
to prevent text from being selected when clicking.summary
text to indicate the contents is a source stack (not “possible sources”).Linkify Element Attribute Values (before/after)
To facilitate investigating the functionality of a script or stylesheet that is being excluded, the URL attribute value is linked to open it in a new tab:
Improve styling of validated URL errors list table (before/after)
Improve styling of validation error list table (before/after)
Improve design of error details shown on the single validation error view (before/after)
Checklist