Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve compatibility tool design and UX #3599

Merged
merged 17 commits into from
Oct 23, 2019

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Oct 22, 2019

Summary

See #2316. Follow up on #3505.

Improve table row styling (before/after)

  • Eliminate zebra striping (shades of red) for new errors is eliminated in favor of gray borders, to align with comments.
  • Improve column widths.

Screen Shot 2019-10-22 at 16 31 11

Screen Shot 2019-10-22 at 16 31 31

Ensure bulk accept/reject buttons cause new state to be cleared for validation errors on validated URL screen (before/after)

This aligns the behavior for when just changing the status in the dropdown.

Screen Shot 2019-10-22 at 16 56 32

Screen Shot 2019-10-22 at 16 57 01

Improve sources list (before/after)

  • Put the entire source stack in a table to ensure alignment.
  • Give details > summary a cursor:pointer and disable user-select to prevent text from being selected when clicking.
  • Improve summary text to indicate the contents is a source stack (not “possible sources”).

Screen Shot 2019-10-22 at 16 36 07

Screen Shot 2019-10-22 at 16 36 24

Linkify Element Attribute Values (before/after)

To facilitate investigating the functionality of a script or stylesheet that is being excluded, the URL attribute value is linked to open it in a new tab:

Screen Shot 2019-10-22 at 16 38 00

Screen Shot 2019-10-22 at 16 37 41

Improve styling of validated URL errors list table (before/after)

Screen Shot 2019-10-22 at 16 39 59

Screen Shot 2019-10-22 at 16 40 19

Improve styling of validation error list table (before/after)

  • Align styling with Comments list table (removing underlines from hyperlinks).
  • Shorten “Found URLs” to just “URLs”
  • Add gray borders between each row (aligning with Comments list table design)

Screen Shot 2019-10-22 at 16 45 13

Screen Shot 2019-10-22 at 16 45 35

Improve design of error details shown on the single validation error view (before/after)

  • Fix positioning of accept/reject button.
  • Show both accept and reject buttons when the error is in a new state.

Screen Shot 2019-10-22 at 16 48 10

Screen Shot 2019-10-22 at 16 49 52

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 22, 2019
@westonruter westonruter added this to the v1.4 milestone Oct 22, 2019
@westonruter westonruter marked this pull request as ready for review October 22, 2019 23:58
@westonruter westonruter requested a review from amedina October 22, 2019 23:58
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@amedina amedina merged commit 6a623c6 into develop Oct 23, 2019
@amedina amedina deleted the update/compatibility-tool-styling branch October 23, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand/collapse all header arrows are not aligned properly
4 participants