Add support for reference points and update spec to file revision 720 (v1534879991178) #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add components for amp-image-slider, amp-viqeo-player, * Add when-ended=continue to amp-date-countdown. * Add [open] to amp-lightbox. * Add disable-double-tap to amp-pan-zoom.
westonruter
changed the title
westonruter
changed the title
westonruter
commented
Aug 31, 2018
| } | ||
| } | ||
| } | ||
| return $rule_spec; |
There was a problem hiding this comment.
Most of this code is refactored into a separate method from below. See 002bda3 for the actual changes introduced.
amedina
reviewed
Sep 1, 2018
| } | ||
| return $rule_spec; | ||
| } | ||
|
|
||
| /** | ||
| * Process a node by sanitizing and/or validating it per. |
There was a problem hiding this comment.
Not related to this change, but this comment may need improvement: validating it per?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-next-page,amp-story,amp-lightbox-gallery, andamp-live-list. This removes hard-coded list of whitelisted attribute pattern which were erroneously being allowed on every element, not just the descendants of elements with reference points.amp-selectorsince its attributes can be added to any descendant not just direct children.amp-image-sliderandamp-viqeo-player.when-ended=continuetoamp-date-countdown.[open]toamp-lightbox.disable-double-taptoamp-pan-zoom.