Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for reference points and update spec to file revision 720 (v1534879991178) #1386

Merged
merged 11 commits into from
Sep 2, 2018
Merged

Add support for reference points and update spec to file revision 720 (v1534879991178) #1386

merged 11 commits into from
Sep 2, 2018

Commits on Aug 30, 2018

  1. Update spec to file revision 720 (v1534879991178) 

    * Add components for amp-image-slider, amp-viqeo-player,
* Add when-ended=continue to amp-date-countdown.
* Add [open] to amp-lightbox.
* Add disable-double-tap to amp-pan-zoom.
    @westonruter
    westonruter committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    e111fa4 View commit details
    Browse the repository at this point in the history

  2. Improve ability to see differences in sanitized markup

    @westonruter
    westonruter committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    549c7b0 View commit details
    Browse the repository at this point in the history

  3. Add tests that intentionally fail, showing reference point problems

    @westonruter
    westonruter committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    e9ffbcb View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. Eliminate whitelisted_attr_regex in favor of data-* attr check

    @westonruter
    westonruter committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    2eb230d View commit details
    Browse the repository at this point in the history

  2. Remove dead code: AMP_Rule_Spec::$node_types_to_remove_if_invalid

    @westonruter
    westonruter committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    596a0c7 View commit details
    Browse the repository at this point in the history

  3. Extract reference points from spec and use attr_spec_list on direct e… 

    …lement children
    @westonruter
    westonruter committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    04ed6a7 View commit details
    Browse the repository at this point in the history

  4. Fix special case of reference point attributes for amp-selector

    @westonruter
    westonruter committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    002bda3 View commit details
    Browse the repository at this point in the history

  5. Split apart code from process_node into smaller get_rule_spec_list_to… 

    …_validate method
    @westonruter
    westonruter committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    38932ff View commit details
    Browse the repository at this point in the history

  6. Add tests for amp-viqeo-player, amp-image-slider, amp-pan-zoom, and a… 

    …mp-lightbox
    @westonruter
    westonruter committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    cb0fd56 View commit details
    Browse the repository at this point in the history

  7. Fix comment regarding reference points being skipped

    @westonruter
    westonruter committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    673206e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2018

  1. Improve docs for AMP_Tag_And_Attribute_Sanitizer::process_node()

    @westonruter
    westonruter committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    0a2916d View commit details
    Browse the repository at this point in the history