Gutenberg: Fix displaying validation warning and usage of PHP function #1612
Conversation
|
Sorry, Will Review Tomorrow Hi @miina, |
|
@kienstra Of course! |
|
Sorry For The Delay Hi @miina, |
|
Looks Good, Request For Review Hi @westonruter, @miina's PR looks good, and it fixes the issue as I understand it. It would be great to have this PR in Here's a feature branch with Miina's commits cherry-picked onto a branch off of Before
After
|
|
I'm re-basing the commits here onto the |
westonruter
force-pushed
the
fix/displaying-validation-warning
branch
from
6f05668
to
34301c1
Compare
westonruter
changed the title
|
|
||
| module.validationWarningNoticeId = wp.data.dispatch( 'core/editor' ).createWarningNotice( noticeElement, { spokenMessage: noticeMessage } ).notice.id; | ||
| wp.data.dispatch( 'core/notices' ).createNotice( 'warning', noticeMessage, noticeOptions ); |
There was a problem hiding this comment.
I'm getting an error here now when attempting to edit an existing post:
There was a problem hiding this comment.
@westonruter Weird, that would indicate as if core/notices wouldn't exist. Is this with the latest version of Gutenberg?
There was a problem hiding this comment.
Humm. I'm not seeing the issue anymore. I opened an incognito window and everything. I'll report if I see it again.
Makes use of
core/notices. Updates creating a warning notice.See #1604.