Use short array syntax throughout the project #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a follow-up to #2493. The main plugin file, `amp.php`, is left untouched as it still should be parseable on PHP 5.2. Also does not change `includes/sanitizers/class-amp-allowed-tags-generated.php` as it is auto-generated.
|
As part of this, the PHPCS ruleset should be updated for force the preferred syntax for consistency. |
|
Of course, good call! |
|
The file is currently excluded from phpcs, and I left it out on purpose because it's auto-generated. Fun Fact: PHPCS actually crashes locally for me because the file is so huge.
Sounds good to me! |
westonruter
approved these changes
Jul 8, 2019
As part the plugin v2.0 effort, I'd like to revisit that file entirely, look at ways it can be made smaller and/or broken up into smaller files. |
westonruter
approved these changes
Jul 8, 2019
|
I was curious: 😅😅😅 |
|
/me shakes fist at Travis… |
westonruter
force-pushed
the
update/short-array-syntax
branch
from
90fbb6e
to
f5c9bf1
Compare
westonruter
force-pushed
the
update/short-array-syntax
branch
from
f5c9bf1
to
ce535e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a follow-up to #2493.
The main plugin file,
amp.php, is left untouched as it still should be parseable on PHP 5.2.Also does not change
includes/sanitizers/class-amp-allowed-tags-generated.phpas it is auto-generated.