Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use short array syntax throughout the project #2767

Merged
merged 4 commits into from
Jul 8, 2019
Merged

Use short array syntax throughout the project #2767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f61374e
Use short array syntax throughout the project
swissspidy Jul 8, 2019
a254fd1
Enforce short array syntax via PHPCS
swissspidy Jul 8, 2019
1c4d1c7
Properly enforce short array syntax using phpcbf
swissspidy Jul 8, 2019
ce535e5
Remove redundant SKIP_ECHO_PATHS_SCOPE=1 since CHECK_SCOPE=all
westonruter Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .dev-lib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,9 @@
DEFAULT_BASE_BRANCH=develop
ASSETS_DIR=wp-assets
PROJECT_SLUG=amp
SKIP_ECHO_PATHS_SCOPE=1
README_MD_TITLE="AMP Plugin for WordPress"
DEV_LIB_SKIP="$DEV_LIB_SKIP,jshint"
if [[ ! -z $TRAVIS ]]; then
CHECK_SCOPE=all
fi
CHECK_SCOPE=all

function after_wp_install {
if [[ "$WP_VERSION" != "4.9" ]]; then
Expand Down
4 changes: 2 additions & 2 deletions back-compat/templates-v0-3/meta-author.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
$post_author = $this->get( 'post_author' );
$avatar_url = get_avatar_url(
$post_author->user_email,
array(
[
'size' => 24,
)
]
);
?>
<li class="amp-wp-byline">
Expand Down
6 changes: 3 additions & 3 deletions back-compat/templates-v0-3/single.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@
<?php do_action( 'amp_post_template_head', $this ); ?>

<style amp-custom>
<?php $this->load_parts( array( 'style' ) ); ?>
<?php $this->load_parts( [ 'style' ] ); ?>
<?php do_action( 'amp_post_template_css', $this ); ?>
</style>
</head>
<body>
<?php $this->load_parts( array( 'header-bar' ) ); ?>
<?php $this->load_parts( [ 'header-bar' ] ); ?>
<div class="amp-wp-content">
<h1 class="amp-wp-title"><?php echo wp_kses_data( $this->get( 'post_title' ) ); ?></h1>
<ul class="amp-wp-meta">
<?php $this->load_parts( apply_filters( 'amp_post_template_meta_parts', array( 'meta-author', 'meta-time', 'meta-taxonomy' ) ) ); ?>
<?php $this->load_parts( apply_filters( 'amp_post_template_meta_parts', [ 'meta-author', 'meta-time', 'meta-taxonomy' ] ) ); ?>
</ul>
<?php echo $this->get( 'post_amp_content' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</div>
Expand Down
Loading