Remove attributes that start with xml #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching to upstream commits - 2/29
|
Realized you might want an example for when users see this. We have twitter embeds that take the form of: <blockquote class="twitter-tweet" lang="en" xml:lang="en"><p>Seville Classics Wide Stacking Shelf, 14" x 30" x 15" (Misc.): $25.02: 34.33% drop: <a href="https://t.co/W73txIfWCO" >https://t.co/W73txIfWCO </a></p>— PriceChirp (@pricechirp) <a href="https://twitter.com/pricechirp/status/704410835653779457" > February 29, 2016</a></blockquote> While this format appears to be legacy, we want to "sanitize" it to prevent amp validation errors. |
…utes to strip. The removed attributes are moved to classes in the form attribute-name_value.
|
Closing as we've moved to a whitelist-based approach #600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the amphtml spec (https://www.ampproject.org/docs/reference/spec.html), XML-related attributes, such as xmlns, xml:lang, xml:base, and xml:space are disallowed in AMP HTML.
This update removes these disallowed attribute.