Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Whitelist Sanitizer #600

Merged
merged 59 commits into from
Apr 28, 2017
Merged

Add Whitelist Sanitizer #600

merged 59 commits into from
Apr 28, 2017

Conversation

delputnam
Copy link
Contributor

Resubmitting after removing some unfinished tests that are not yet working. Sorry about that.
//cc @mjangda

Del Putnam and others added 30 commits December 14, 2016 11:46
Initial commit to allowed-tags-sanitizer branch.
e975181
Adding generated amp allowed tags and initial copy of allowed-tags-sa…
47fd538 
…nitizer class.
Adding initial version of python script to generate allowed tags list
ec1637d
@delputnam
Add alternate names for allowed attributes and globally allowed attri…
6f43c22 
…butes.
@delputnam
Completed python code to generate full attr_spec lists.
71d160c
@delputnam
Added the rest of the tag_spec rules.
9430d36
@delputnam
Added spec_url and spec_name. Also corrected header text and removed …
0585ff8 
…non-body elements from generated php.
@delputnam
Include tag in .
5b46e77
@delputnam
Wrapped tag and attribute definitions in a class.
babec99
@delputnam
Adding basic whitelist sanitizer proof-of-concept.
e7e51f0
@delputnam
Converted 'True' and 'False' strings into true and false bools in gen…
589385c 
…erated php.
@delputnam
check for mandatory attributes and values during validation
9e0c629
@delputnam
Include check for mandatory attributes alternate names.
2fb2aad
@delputnam
Added protocol checks to attr_spec validation.
09f175e
@delputnam
Added relative url check for attr rules.
db857e7
@delputnam
Added disallowed empty attribute check.
a3fe590
@delputnam
Added disallowed domain checks.
4a1cda3
@delputnam
Remove disallowed attributes and blacklisted attribute values from no…
1f64134 
…des.
@delputnam
Check for empty array before deleting attributes from the attrs_to_re…
e50207a 
…move array.
@delputnam
Remove disallowed attribute values.
14de8eb
@delputnam
Removed some unused commented out code.
b89f5dc
@delputnam
Some optimizations to reduce the number of extraneous function calls.
ffcca80
@delputnam
Changed name of sanitizer to better reflect its actual function.
22fa869
@delputnam
Fixed class and file name and references.
dbdb95b
@delputnam
Better attr_spec validation
971f6d6
@delputnam
Adding tests.
ae3596e
@delputnam
Added tag/attr_spec validation filters.
2a4644a
@delputnam
Moved all sanitizers to filters.
08f576b
@delputnam
More consistent function naming.
9aaf807
@delputnam
Unit tests for validation functions.
49bf688
@delputnam
Optimization: removed checking for allowed protocol in loop and repla…
c420698 
…ced with .
@delputnam
Added benchmark test data with AMP errors.
87fd611
@delputnam
Better banchmark output.
68da2ad
@delputnam
Benchmark script to generate combined cachegrind output for multiple …
a598ec9 
…profiling runs.
@delputnam
Added tests for multiple srcset URLs without src attribute and bug fi…
74bb6e0 
…xes for srcset attribute.
@delputnam
Allow attributes by whitelisted regex (speficically data-*)
d47fd4d
@delputnam
Moved layout allowed attributes to generated class file.
79f8bd1
@delputnam
Allow experimental tags ('amp-share-tracking') with no protoascii file
7e5b1f9
@delputnam
Commented out section to write sanitized data to file for analysis.
b5e50eb
@delputnam
Added comments at top of the file to explain how to use it to generat…
7e38560 
…e class-amp-allowed-tags-generated.php
@delputnam
Added comments to all attribute rule test functions.
23c88cd
@delputnam
Skip processing of CDATA, to allow necessary javascript in nodes such…
933512c 
… as analytics
@delputnam
Temporarily remove bad script tests.
2361ae6
@delputnam
More tests
eee8c25
@delputnam
Removed extraneous files from benchmark test data
702eaab
@delputnam
Fixed typo in global variable declaration.
32a2c58
@delputnam
Removed unfinished attribute tests that should not work yet.
fa2d0bd
@delputnam
Moving const arrays to static arrays to support older versions of php.
1389956
@delputnam
Temporarily disabling tests that use ReflectionMethod::setAccessible …
5e00162 
…for compatibility with php versions prior to 5.3.2
@delputnam
Removed benchmark from tests since this is not really a unit test.
4eb4b39
@delputnam
Moved private function tests to different file/testunit
87af18c
@delputnam
Handle edge cases for url checks with multiple values or alternative …
1cbcb07 
…attribute names. Also, more unit tests.
@mjangda mjangda changed the title Resubmitting new whitelist sanitizer Add Whitelist Sanitizer Apr 23, 2017
@mjangda mjangda merged commit 3c69b21 into ampproject:master Apr 28, 2017
@mjangda mjangda mentioned this pull request Apr 28, 2017
Closed
6 tasks
This was referenced Jul 14, 2017
Closed
Closed
Closed
@westonruter westonruter mentioned this pull request Nov 7, 2017
Closed
@westonruter westonruter mentioned this pull request Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delputnam @mjangda