Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Whitelist Sanitizer #600

Merged
merged 59 commits into from
Apr 28, 2017
Merged

Add Whitelist Sanitizer #600

merged 59 commits into from
Apr 28, 2017

Commits on Dec 14, 2016

  1. Initial commit to allowed-tags-sanitizer branch.

    Del Putnam committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    e975181 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2016

  1. Adding generated amp allowed tags and initial copy of allowed-tags-sa… 

    …nitizer class.
    Del Putnam authored and Del Putnam committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    47fd538 View commit details
    Browse the repository at this point in the history

  2. Adding initial version of python script to generate allowed tags list

    Del Putnam authored and Del Putnam committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    ec1637d View commit details
    Browse the repository at this point in the history

  3. Add alternate names for allowed attributes and globally allowed attri… 

    …butes.
    @delputnam
    delputnam committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    6f43c22 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2016

  1. Completed python code to generate full attr_spec lists.

    @delputnam
    delputnam committed Dec 18, 2016
    Configuration menu
    Copy the full SHA
    71d160c View commit details
    Browse the repository at this point in the history

  2. Added the rest of the tag_spec rules.

    @delputnam
    delputnam committed Dec 18, 2016
    Configuration menu
    Copy the full SHA
    9430d36 View commit details
    Browse the repository at this point in the history

  3. Added spec_url and spec_name. Also corrected header text and removed … 

    …non-body elements from generated php.
    @delputnam
    delputnam committed Dec 18, 2016
    Configuration menu
    Copy the full SHA
    0585ff8 View commit details
    Browse the repository at this point in the history

  4. Include tag in .

    @delputnam
    delputnam committed Dec 18, 2016
    Configuration menu
    Copy the full SHA
    5b46e77 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2016

  1. Wrapped tag and attribute definitions in a class.

    @delputnam
    delputnam committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    babec99 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2016

  1. Adding basic whitelist sanitizer proof-of-concept.

    @delputnam
    delputnam committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    e7e51f0 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2016

  1. Converted 'True' and 'False' strings into true and false bools in gen… 

    …erated php.
    @delputnam
    delputnam committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    589385c View commit details
    Browse the repository at this point in the history

  2. check for mandatory attributes and values during validation

    @delputnam
    delputnam committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    9e0c629 View commit details
    Browse the repository at this point in the history

  3. Include check for mandatory attributes alternate names.

    @delputnam
    delputnam committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    2fb2aad View commit details
    Browse the repository at this point in the history

  4. Added protocol checks to attr_spec validation.

    @delputnam
    delputnam committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    09f175e View commit details
    Browse the repository at this point in the history

  5. Added relative url check for attr rules.

    @delputnam
    delputnam committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    db857e7 View commit details
    Browse the repository at this point in the history

  6. Added disallowed empty attribute check.

    @delputnam
    delputnam committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    a3fe590 View commit details
    Browse the repository at this point in the history

  7. Added disallowed domain checks.

    @delputnam
    delputnam committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    4a1cda3 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2016

  1. Remove disallowed attributes and blacklisted attribute values from no… 

    …des.
    @delputnam
    delputnam committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    1f64134 View commit details
    Browse the repository at this point in the history

  2. Check for empty array before deleting attributes from the attrs_to_re… 

    …move array.
    @delputnam
    delputnam committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    e50207a View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2016

  1. Remove disallowed attribute values.

    @delputnam
    delputnam committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    14de8eb View commit details
    Browse the repository at this point in the history

  2. Removed some unused commented out code.

    @delputnam
    delputnam committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    b89f5dc View commit details
    Browse the repository at this point in the history

  3. Some optimizations to reduce the number of extraneous function calls.

    @delputnam
    delputnam committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    ffcca80 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2016

  1. Changed name of sanitizer to better reflect its actual function.

    @delputnam
    delputnam committed Dec 24, 2016
    Configuration menu
    Copy the full SHA
    22fa869 View commit details
    Browse the repository at this point in the history

  2. Fixed class and file name and references.

    @delputnam
    delputnam committed Dec 24, 2016
    Configuration menu
    Copy the full SHA
    dbdb95b View commit details
    Browse the repository at this point in the history

  3. Better attr_spec validation

    @delputnam
    delputnam committed Dec 24, 2016
    Configuration menu
    Copy the full SHA
    971f6d6 View commit details
    Browse the repository at this point in the history

  4. Adding tests.

    @delputnam
    delputnam committed Dec 24, 2016
    Configuration menu
    Copy the full SHA
    ae3596e View commit details
    Browse the repository at this point in the history

  5. Added tag/attr_spec validation filters.

    @delputnam
    delputnam committed Dec 24, 2016
    Configuration menu
    Copy the full SHA
    2a4644a View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2016

  1. Moved all sanitizers to filters.

    @delputnam
    delputnam committed Dec 25, 2016
    Configuration menu
    Copy the full SHA
    08f576b View commit details
    Browse the repository at this point in the history

  2. More consistent function naming.

    @delputnam
    delputnam committed Dec 25, 2016
    Configuration menu
    Copy the full SHA
    9aaf807 View commit details
    Browse the repository at this point in the history

  3. Unit tests for validation functions.

    @delputnam
    delputnam committed Dec 25, 2016
    Configuration menu
    Copy the full SHA
    49bf688 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2016

  1. Initial commit of benchmark tests.

    @delputnam
    delputnam committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    71ab56b View commit details
    Browse the repository at this point in the history

  2. Additional tests to allow some sanitizers to fail faster for performa… 

    …nce improvements.
    @delputnam
    delputnam committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    17ee3b5 View commit details
    Browse the repository at this point in the history

  3. Removed filters and combined some functions to improve performance.

    @delputnam
    delputnam committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    9af5b73 View commit details
    Browse the repository at this point in the history

  4. Fixed typos

    @delputnam
    delputnam committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    52844a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2016

  1. Fixed comments

    @delputnam
    delputnam committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    812b137 View commit details
    Browse the repository at this point in the history

  2. Unit tests update

    @delputnam
    delputnam committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    b15e997 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2016

  1. Moved all benchmark data to subdirectory tests/benchmark/test-data.

    @delputnam
    delputnam committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    1ebe8f3 View commit details
    Browse the repository at this point in the history

  2. Optimization: removed checking for allowed protocol in loop and repla… 

    …ced with .
    @delputnam
    delputnam committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    c420698 View commit details
    Browse the repository at this point in the history

  3. Added benchmark test data with AMP errors.

    @delputnam
    delputnam committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    87fd611 View commit details
    Browse the repository at this point in the history

  4. Better banchmark output.

    @delputnam
    delputnam committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    68da2ad View commit details
    Browse the repository at this point in the history

  5. Benchmark script to generate combined cachegrind output for multiple … 

    …profiling runs.
    @delputnam
    delputnam committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    a598ec9 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2016

  1. Added tests for multiple srcset URLs without src attribute and bug fi… 

    …xes for srcset attribute.
    @delputnam
    delputnam committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    74bb6e0 View commit details
    Browse the repository at this point in the history

  2. Allow attributes by whitelisted regex (speficically data-*)

    @delputnam
    delputnam committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    d47fd4d View commit details
    Browse the repository at this point in the history

  3. Moved layout allowed attributes to generated class file.

    @delputnam
    delputnam committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    79f8bd1 View commit details
    Browse the repository at this point in the history

  4. Allow experimental tags ('amp-share-tracking') with no protoascii file

    @delputnam
    delputnam committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    7e5b1f9 View commit details
    Browse the repository at this point in the history

  5. Commented out section to write sanitized data to file for analysis.

    @delputnam
    delputnam committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    b5e50eb View commit details
    Browse the repository at this point in the history

  6. Added comments at top of the file to explain how to use it to generat… 

    …e class-amp-allowed-tags-generated.php
    @delputnam
    delputnam committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    7e38560 View commit details
    Browse the repository at this point in the history

  7. Added comments to all attribute rule test functions.

    @delputnam
    delputnam committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    23c88cd View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2016

  1. Skip processing of CDATA, to allow necessary javascript in nodes such… 

    … as analytics
    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    933512c View commit details
    Browse the repository at this point in the history

  2. Temporarily remove bad script tests.

    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    2361ae6 View commit details
    Browse the repository at this point in the history

  3. More tests

    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    eee8c25 View commit details
    Browse the repository at this point in the history

  4. Removed extraneous files from benchmark test data

    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    702eaab View commit details
    Browse the repository at this point in the history

  5. Fixed typo in global variable declaration.

    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    32a2c58 View commit details
    Browse the repository at this point in the history

  6. Removed unfinished attribute tests that should not work yet.

    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    fa2d0bd View commit details
    Browse the repository at this point in the history

  7. Moving const arrays to static arrays to support older versions of php.

    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    1389956 View commit details
    Browse the repository at this point in the history

  8. Temporarily disabling tests that use ReflectionMethod::setAccessible … 

    …for compatibility with php versions prior to 5.3.2
    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    5e00162 View commit details
    Browse the repository at this point in the history

  9. Removed benchmark from tests since this is not really a unit test.

    @delputnam
    delputnam committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    4eb4b39 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2017

  1. Moved private function tests to different file/testunit

    @delputnam
    delputnam committed Jan 1, 2017
    Configuration menu
    Copy the full SHA
    87af18c View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2017

  1. Handle edge cases for url checks with multiple values or alternative … 

    …attribute names. Also, more unit tests.
    @delputnam
    delputnam committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    1cbcb07 View commit details
    Browse the repository at this point in the history