Eliminate no-global-event-listener ESLint warnings #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5732 +/- ##
==========================================
Coverage 73.66% 73.66%
Complexity 5429 5429
==========================================
Files 186 186
Lines 16375 16375
==========================================
Hits 12063 12063
Misses 4312 4312
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Plugin builds for b406119 are ready 🛎️!
|
pierlon
suggested changes
Dec 22, 2020
| @@ -46,10 +46,12 @@ const addBeforeUnloadPrompt = () => { | |||
| if ( beforeUnloadPromptAdded ) { | |||
| return; | |||
| } | |||
| // eslint-disable-next-line @wordpress/no-global-event-listener | |||
| window.addEventListener( 'beforeunload', onBeforeUnload ); | |||
There was a problem hiding this comment.
You should be able to use global here since the file is being transpiled via Webpack, which would then provide reference to window.
There was a problem hiding this comment.
Good points. Might as well use global in all these instances. Updated in 747061f
| window.addEventListener( 'beforeunload', onBeforeUnload ); | ||
|
|
||
| // Remove prompt when clicking trash or update. | ||
| document.querySelector( '#major-publishing-actions' ).addEventListener( 'click', () => { | ||
| // eslint-disable-next-line @wordpress/no-global-event-listener | ||
| window.removeEventListener( 'beforeunload', onBeforeUnload ); |
There was a problem hiding this comment.
Updated in 747061f
| @@ -144,6 +144,7 @@ class ErrorRows { | |||
| } ); | |||
| }; | |||
|
|
|||
| // eslint-disable-next-line @wordpress/no-global-event-listener | |||
| window.addEventListener( 'click', ( event ) => { | |||
There was a problem hiding this comment.
Updated in 747061f
pierlon
approved these changes
Dec 23, 2020
westonruter
reviewed
Dec 23, 2020
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5731
This eliminates the
@wordpress/no-global-event-listenerESLint warnings shown in #5731. A few different approaches were used:usedeslint-disable-next-lineto the three lines that had the issueglobalis used instead ofwindow.UnsavedChangesWarningcomponent, passed in the app root and used the root'sownerDocument, because doing so was simple.useWindowWidthhook, replacedwindowwithglobalbecause that hook is intended to use the global window.Checklist