Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for core themes mobile menus #6933

Merged
merged 15 commits into from
Mar 8, 2022
Merged

Add E2E tests for core themes mobile menus #6933

merged 15 commits into from
Mar 8, 2022

Conversation

delawski
Copy link
Collaborator

Summary

Fixes #5404

This PR adds end to end tests for mobile navigation toggle for the following core themes:

  • Twenty Twelve
  • Twenty Thirteen
  • Twenty Fourteen
  • Twenty Fifteen
  • Twenty Sixteen
  • Twenty Seventeen
  • Twenty Nineteen
  • Twenty Twenty (a search modal is also checked for this theme)
  • Twenty Twenty-One

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@delawski delawski added the Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs label Feb 23, 2022
@delawski delawski added this to the v2.2.2 milestone Feb 23, 2022
@delawski delawski self-assigned this Feb 23, 2022
@github-actions
Copy link
Contributor

Plugin builds for d892636 are ready 🛎️!

westonruter
westonruter reviewed Mar 8, 2022
View reviewed changes
tests/e2e/specs/core-themes/twentytwenty.js
} );
} );

describe( 'search modal on desktop', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@westonruter
Copy link
Member

This PR adds end to end tests for mobile navigation toggle for the following core themes:

It would be good to add Twenty Twenty-Two since that would capture FSE themes in general, but that can be done later.

@westonruter westonruter merged commit e74b7bd into develop Mar 8, 2022
@westonruter westonruter deleted the add/5404-e2e-tests-for-theme-nav-toggle branch March 8, 2022 23:32
westonruter added a commit that referenced this pull request Mar 8, 2022
@westonruter @delawski
Add E2E tests for core themes mobile menus (#6933)
e6686fd 
Co-authored-by: Piotr Delawski <piotr.delawski@gmail.com>
@westonruter westonruter mentioned this pull request Mar 9, 2022
Merged
2 tasks
@delawski delawski mentioned this pull request Mar 9, 2022
Merged
2 tasks
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@dhaval-parekh dhaval-parekh Awaiting requested review from dhaval-parekh

Assignees

@delawski delawski

Labels
Changelogged Whether the issue/PR has been added to release notes. Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

Add E2E tests for the nav menu toggle
2 participants
@delawski @westonruter