Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky e2e tests #7488

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Fix flaky e2e tests #7488

merged 2 commits into from
Mar 16, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Mar 16, 2023

Summary

  • Fix core-themes flaky e2e tests.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh force-pushed the fix/flaky-e2e-tests branch from 3f90087 to 53a3c31 Compare March 16, 2023 15:52
@thelovekesh thelovekesh marked this pull request as ready for review March 16, 2023 16:21
@thelovekesh thelovekesh requested a review from westonruter March 16, 2023 16:22
@github-actions
Copy link
Contributor

Plugin builds for 0dedc64 are ready 🛎️!

@westonruter westonruter added this to the v2.4.1 milestone Mar 16, 2023
@westonruter westonruter merged commit 96cdfb9 into develop Mar 16, 2023
@westonruter westonruter deleted the fix/flaky-e2e-tests branch March 16, 2023 18:12
@thelovekesh
Copy link
Collaborator Author

QA Passed ✅

Before, e2e tests were failing frequently owing to flakiness in core-themes specs, which hasn't been discovered after these modifications were introduced.

GHA logs for this can also be used to examine several attempts to ensure that e2e tests don't exhibit flaky behavior.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants