Remove React 17 requirement for AfterActivationSiteScan service
#7490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelovekesh
force-pushed
the
revert/7421
branch
from
4e324d8
to
e116446
Compare
|
Plugin builds for ba02543 are ready 🛎️!
|
- Why? React 17 code will continue to work with React 18 by invoking a legacy API
thelovekesh
force-pushed
the
revert/7421
branch
from
e116446
to
ba02543
Compare
thelovekesh
changed the title
AfterActivationSiteScan service
thelovekesh
commented
Mar 16, 2023
| @@ -23,9 +23,6 @@ cd "$(dirname "$0")/../.." | |||
| # done on every time `npm run test-e2e` is run. | |||
| . "$(dirname "$0")/install-wordpress.sh" | |||
|
|
|||
| # Install specific version of Gutenberg plugin for e2e tests. | |||
| download_gutenberg "14.7.3" "tests/e2e/plugins/gutenberg.14.7.3.zip" | |||
There was a problem hiding this comment.
Just in case we ever need it, should we leave the download_gutenberg util function in place?
There was a problem hiding this comment.
Same for uploads.ini
amp-wp/bin/local-env/docker-compose.yml
Line 13 in 96cdfb9
There was a problem hiding this comment.
We could, but probably better to remove it. It can be resurrected via version control if needed.
|
Looks like flakiness in e2e is still there, even after #7488. |
thelovekesh
assigned westonruter and thelovekesh and unassigned westonruter and thelovekesh
|
QA Passed ✅ Verified the issue, the site scan function is working fine with the React 18 and WP6.2 current RC version.
|
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7489
Checklist