Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot config to group @wordpress/* package updates #7579

Merged
merged 5 commits into from
Jul 11, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@ updates:
time: "17:00"
timezone: America/Los_Angeles
open-pull-requests-limit: 10
groups:
wordpress-packages:
patterns:
- "@wordpress/*"
ignore:
# Cannot upgrade until @wordpress/element supports react v17.
# Need to be updated based on `@wordpress/element` react peer dependency version.
- dependency-name: react
versions:
- ">= 17"
# Updates are handled via the `gutenberg-packages-update` GHA workflow.
- dependency-name: "@wordpress/*"
- dependency-name: react-dom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you realize you needed to add react-dom?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @wordpress/element is an abstraction on both and need to match its peer deps version, I think it would be better to add both.


# Config for GitHub Actions.
- package-ecosystem: github-actions
Expand Down