Update dependabot config to group @wordpress/* package updates
#7579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed in favor of dependabot updates grouping.
|
Plugin builds for 3386b9b are ready 🛎️!
|
|
Normalize composer issue is fixed in #7580. |
westonruter
reviewed
Jul 10, 2023
| - ">= 17" | ||
| # Updates are handled via the `gutenberg-packages-update` GHA workflow. | ||
| - dependency-name: "@wordpress/*" | ||
| - dependency-name: react-dom |
There was a problem hiding this comment.
How did you realize you needed to add react-dom?
There was a problem hiding this comment.
Since @wordpress/element is an abstraction on both and need to match its peer deps version, I think it would be better to add both.
westonruter
reviewed
Jul 10, 2023
Comment on lines
+180
to
+190
| # Check if phar is actually downloaded. | ||
| if [ ! -f composer-normalize.phar ]; then | ||
| sleep 5 | ||
| wget https://github.com/ergebnis/composer-normalize/releases/latest/download/composer-normalize.phar | ||
| fi | ||
|
|
||
| # If not downloaded, exit with error this time. | ||
| if [ ! -f composer-normalize.phar ]; then | ||
| echo "::error::Failed to download composer-normalize.phar" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Was the file failing to download?
There was a problem hiding this comment.
Yup on my local once among many attempts. So added this safeguard.
westonruter
approved these changes
Jul 10, 2023
thelovekesh
added
Bug
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gutenberg packages updateworkflow in favor of @dependabot dependency updates grouping.Fixes #7576
Checklist