Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependabot config to group @wordpress/* package updates #7579

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Update dependabot config to group @wordpress/* package updates #7579

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c5a6db
Update dependabot config to group `@wordpress/*` package updates
thelovekesh Jul 10, 2023
d2a02c0
Remove `Gutenberg packages update` workflow
thelovekesh Jul 10, 2023
583d624
Update `normalize-composer` job to be more robust
thelovekesh Jul 10, 2023
a6fe249
Merge branch 'develop' into add/groups-dependabot-config
westonruter Jul 10, 2023
3386b9b
Merge branch 'develop' into add/groups-dependabot-config
thelovekesh Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@ updates:
time: "17:00"
timezone: America/Los_Angeles
open-pull-requests-limit: 10
groups:
wordpress-packages:
patterns:
- "@wordpress/*"
ignore:
# Cannot upgrade until @wordpress/element supports react v17.
# Need to be updated based on `@wordpress/element` react peer dependency version.
- dependency-name: react
versions:
- ">= 17"
# Updates are handled via the `gutenberg-packages-update` GHA workflow.
- dependency-name: "@wordpress/*"
- dependency-name: react-dom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you realize you needed to add react-dom?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @wordpress/element is an abstraction on both and need to match its peer deps version, I think it would be better to add both.


# Config for GitHub Actions.
- package-ecosystem: github-actions
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/build-test-measure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,19 @@ jobs:
- name: Get composer-normalize.phar
run: |
wget https://github.com/ergebnis/composer-normalize/releases/latest/download/composer-normalize.phar

# Check if phar is actually downloaded.
if [ ! -f composer-normalize.phar ]; then
sleep 5
wget https://github.com/ergebnis/composer-normalize/releases/latest/download/composer-normalize.phar
fi

# If not downloaded, exit with error this time.
if [ ! -f composer-normalize.phar ]; then
echo "::error::Failed to download composer-normalize.phar"
exit 1
fi
Comment on lines +180 to +190
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the file failing to download?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup on my local once among many attempts. So added this safeguard.


chmod +x composer-normalize.phar

- name: Validate composer.json
Expand Down
188 changes: 0 additions & 188 deletions .github/workflows/gutenberg-packages-update.yml
View file
Open in desktop

This file was deleted.