Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: Cannot read property 'src' of undefined #28582

Closed
ampprojectbot opened this issue May 26, 2020 · 1 comment · Fixed by #29042
Closed

🚨 Error: Cannot read property 'src' of undefined #28582

ampprojectbot opened this issue May 26, 2020 · 1 comment · Fixed by #29042
Assignees
Labels
P1: High Priority Type: Error Report An error reported by AMP Error Reporting WG: runtime

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: May 16, 2020
Frequency: ~ 311/day

Stacktrace

Error: Cannot read property 'src' of undefined
    at scriptsInHead (src/service/extensions-impl.js:556:29)
    at Promise (src/runtime.js:300:11)
    at fnOrStruct (src/runtime.js:191:53)
    at src/service/standard-actions-impl.js:45:2

Notes

@jridgewell modified src/service/extensions-impl.js:555-556 in #28250 (May 7, 2020)
@erwinmombay modified src/runtime.js:298-303 in #16660 (Jul 18, 2018)
@peterjosling modified src/runtime.js:191-191 in #14922 (Apr 30, 2018)
@alanorozco modified src/service/standard-actions-impl.js:39-50 in #20687 (Feb 6, 2019)

Seen in:

  • 05-15 Beta (0002)
  • 05-15 Experimental (0002)

Possible assignees: @jridgewell, @alanorozco

/cc @ampproject/release-on-duty

@dreamofabear
Copy link

Bumping priority since this bug is breaking render of some ads that have duplicate extension scripts. Looking at the error reporter, seems like there are at least 5 distinct codepaths that trigger this.

Simple fix is to just soft-fail instead of unwinding the stack due to a runtime error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: High Priority Type: Error Report An error reported by AMP Error Reporting WG: runtime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants