Allow reloadExtension() to soft fail #29042
Conversation
dreamofabear
requested review from
jridgewell
and removed request for
kristoferbaxter
src/service/extensions-impl.js
Outdated
| ); | ||
| if (!els.length) { | ||
| const TAG = 'reloadExtension'; | ||
| user().warn( |
There was a problem hiding this comment.
Let's make this an error
There was a problem hiding this comment.
There's already a different error for this: Error: amp-fit-text is already registered. The script tag for amp-fit-text is likely included twice in the page.
Happens in custom-element-registry.js when we try to register a CE twice.
There was a problem hiding this comment.
That happens too late, though, since any side-effects in the code can already execute. I think we need an earlier check in runtime.js when we're processing the pushed ExtensionPayload.
There was a problem hiding this comment.
Right and it doesn't cover non-CE extensions. I guess we have a similar check for templates. #29050
There was a problem hiding this comment.
This got off topic from the request. Let's make this an error, not a warn.
We can solve the escape hatch in a follow up.
Fixes #28582 and
b/158855528.